Skip to content

Commit cd803da

Browse files
sremmind
authored andcommitted
arm64: dts: rockchip: fix PHY handling for ROCK 4D
Old revisions of the ROCK 4D board have a dedicated crystal to supply the RTL8211F PHY's 25MHz clock input. At least some newer revisions instead use REFCLKO25M_GMAC0_OUT. The DT already has this half-prepared, but there are some issues: 1. The DT relies on auto-selecting the right PHY driver, which requires that it works good enough to read the ID registers. This does not work without the clock, which is handled by the PHY driver. By updating the compatible to contain the RTL8211F IDs, so that the operating system can choose the right PHY driver without relying on a pre-powered PHY. 2. Despite the name REFCLKO25M_GMAC0_OUT could also provide a different frequency, so ensure it is explicitly set to 25 MHz as expected by the PHY. 3. While at it switch from deprecated "enable-gpio" to standard "enable-gpios". Fixes: a0fb7ec ("arm64: dts: rockchip: Add Radxa ROCK 4D device tree") Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> Link: https://lore.kernel.org/r/20250704-rk3576-rock4d-phy-handling-fixes-v1-1-1d64130c4139@kernel.org Signed-off-by: Heiko Stuebner <heiko@sntech.de>
1 parent 06b29cb commit cd803da

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -645,14 +645,16 @@
645645

646646
&mdio0 {
647647
rgmii_phy0: ethernet-phy@1 {
648-
compatible = "ethernet-phy-ieee802.3-c22";
648+
compatible = "ethernet-phy-id001c.c916";
649649
reg = <0x1>;
650650
clocks = <&cru REFCLKO25M_GMAC0_OUT>;
651+
assigned-clocks = <&cru REFCLKO25M_GMAC0_OUT>;
652+
assigned-clock-rates = <25000000>;
651653
pinctrl-names = "default";
652654
pinctrl-0 = <&rtl8211f_rst>;
653655
reset-assert-us = <20000>;
654656
reset-deassert-us = <100000>;
655-
reset-gpio = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
657+
reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
656658
};
657659
};
658660

0 commit comments

Comments
 (0)