smb: client: Use common code in cifs_do_create()

elfring · smfrench · commit ce47f7498598 · 2025-10-07T13:31:27.000-05:00
Use a label once more so that a bit of common code can be better reused
at the end of this function implementation.

Signed-off-by: Markus Elfring &lt;elfring@users.sourceforge.net&gt;
Acked-by: Enzo Matsumiya &lt;ematsumiya@suse.de&gt;
Reviewed-by: David Howells &lt;dhowells@redhat.com&gt;
Signed-off-by: Steve French &lt;stfrench@microsoft.com&gt;
diff --git a/fs/smb/client/dir.c b/fs/smb/client/dir.c
@@ -200,8 +200,8 @@ static int cifs_do_create(struct inode *inode, struct dentry *direntry, unsigned
 
 	full_path = build_path_from_dentry(direntry, page);
 	if (IS_ERR(full_path)) {
-		free_dentry_path(page);
-		return PTR_ERR(full_path);
+		rc = PTR_ERR(full_path);
+		goto out;
 	}
 
 	/* If we're caching, we need to be able to fill in around partial writes. */

Original file line number	Diff line number	Diff line change
`@@ -200,8 +200,8 @@ static int cifs_do_create(struct inode inode, struct dentry direntry, unsigned`
`200`	`200`
`201`	`201`	`full_path = build_path_from_dentry(direntry, page);`
`202`	`202`	`if (IS_ERR(full_path)) {`
`203`		`- free_dentry_path(page);`
`204`		`- return PTR_ERR(full_path);`
	`203`	`+ rc = PTR_ERR(full_path);`
	`204`	`+ goto out;`
`205`	`205`	`}`
`206`	`206`
`207`	`207`	`/* If we're caching, we need to be able to fill in around partial writes. */`