Skip to content

Commit cfb1ea2

Browse files
glemcorostedt
authored andcommitted
rtla: Fix consistency in getopt_long for timerlat_hist
Commit e9a4062 ("rtla: Add --trace-buffer-size option") adds a new long option to rtla utilities, but among all affected files, timerlat_hist misses a trailing `:` in the corresponding short option inside the getopt string (e.g. `\3:`). This patch propagates the `:`. Although this change is not functionally required, it improves consistency and slightly reduces the likelihood a future change would introduce a problem. Cc: John Kacur <jkacur@redhat.com> Cc: Luis Goncalves <lgoncalv@redhat.com> Cc: Tomas Glozar <tglozar@redhat.com> Link: https://lore.kernel.org/20240926143417.54039-1-gmonaco@redhat.com Signed-off-by: Gabriele Monaco <gmonaco@redhat.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent ac1987f commit cfb1ea2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/tracing/rtla/src/timerlat_hist.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -778,7 +778,7 @@ static struct timerlat_hist_params
778778
/* getopt_long stores the option index here. */
779779
int option_index = 0;
780780

781-
c = getopt_long(argc, argv, "a:c:C::b:d:e:E:DhH:i:knp:P:s:t::T:uU0123456:7:8:9\1\2:\3",
781+
c = getopt_long(argc, argv, "a:c:C::b:d:e:E:DhH:i:knp:P:s:t::T:uU0123456:7:8:9\1\2:\3:",
782782
long_options, &option_index);
783783

784784
/* detect the end of the options. */

0 commit comments

Comments
 (0)