Skip to content

Commit cfe54f4

Browse files
leitaoardbiesheuvel
authored andcommitted
kthread: Warn if mm_struct lacks user_ns in kthread_use_mm()
Add a WARN_ON_ONCE() check to detect mm_struct instances that are missing user_ns initialization when passed to kthread_use_mm(). When a kthread adopts an mm via kthread_use_mm(), LSM hooks and capability checks may access current->mm->user_ns for credential validation. If user_ns is NULL, this leads to a NULL pointer dereference crash. This was observed with efi_mm on arm64, where commit a5baf58 ("arm64/efi: Call EFI runtime services without disabling preemption") introduced kthread_use_mm(&efi_mm), but efi_mm lacked user_ns initialization, causing crashes during /proc access. Adding this warning helps catch similar bugs early during development rather than waiting for hard-to-debug NULL pointer crashes in production. Signed-off-by: Breno Leitao <leitao@debian.org> Acked-by: Rik van Riel <riel@surriel.com> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
1 parent 61ed08c commit cfe54f4

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

kernel/kthread.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1599,6 +1599,7 @@ void kthread_use_mm(struct mm_struct *mm)
15991599

16001600
WARN_ON_ONCE(!(tsk->flags & PF_KTHREAD));
16011601
WARN_ON_ONCE(tsk->mm);
1602+
WARN_ON_ONCE(!mm->user_ns);
16021603

16031604
/*
16041605
* It is possible for mm to be the same as tsk->active_mm, but

0 commit comments

Comments
 (0)