rtc: hym8563: fix incorrect maximum clock rate handling

masneyb · alexandrebelloni · commit d0a518eb0a69 · 2025-08-03T02:57:05.000+02:00
When hym8563_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: dcaf038 ("rtc: add hym8563 rtc-driver") Signed-off-by: Brian Masney <bmasney@redhat.com> Link: https://lore.kernel.org/r/20250710-rtc-clk-round-rate-v1-2-33140bb2278e@redhat.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c
@@ -294,7 +294,7 @@ static long hym8563_clkout_round_rate(struct clk_hw *hw, unsigned long rate,
 		if (clkout_rates[i] <= rate)
 			return clkout_rates[i];
 
-	return 0;
+	return clkout_rates[0];
 }
 
 static int hym8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate,

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ static long hym8563_clkout_round_rate(struct clk_hw *hw, unsigned long rate,`
`294`	`294`	`if (clkout_rates[i] <= rate)`
`295`	`295`	`return clkout_rates[i];`
`296`	`296`
`297`		`- return 0;`
	`297`	`+ return clkout_rates[0];`
`298`	`298`	`}`
`299`	`299`
`300`	`300`	`static int hym8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate,`