thermal/drivers/imx: Simplify with dev_err_probe()

krzk · dlezcano · commit d0b297e76b5c · 2024-07-15T13:31:40.000+02:00
Error handling in probe() can be a bit simpler with dev_err_probe(). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20240709-thermal-probe-v1-8-241644e2b6e0@linaro.org Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
@@ -679,9 +679,7 @@ static int imx_thermal_probe(struct platform_device *pdev)
 
 	data->thermal_clk = devm_clk_get(dev, NULL);
 	if (IS_ERR(data->thermal_clk)) {
-		ret = PTR_ERR(data->thermal_clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(dev, "failed to get thermal clk: %d\n", ret);
+		ret = dev_err_probe(dev, PTR_ERR(data->thermal_clk), "failed to get thermal clk\n");
 		goto legacy_cleanup;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -679,9 +679,7 @@ static int imx_thermal_probe(struct platform_device *pdev)`
`679`	`679`
`680`	`680`	`data->thermal_clk = devm_clk_get(dev, NULL);`
`681`	`681`	`if (IS_ERR(data->thermal_clk)) {`
`682`		`- ret = PTR_ERR(data->thermal_clk);`
`683`		`- if (ret != -EPROBE_DEFER)`
`684`		`- dev_err(dev, "failed to get thermal clk: %d\n", ret);`
	`682`	`+ ret = dev_err_probe(dev, PTR_ERR(data->thermal_clk), "failed to get thermal clk\n");`
`685`	`683`	`goto legacy_cleanup;`
`686`	`684`	`}`
`687`	`685`