fs/ntfs3: Additional check in ni_clear()

aalexandrovich · aalexandrovich · commit d178944db36b · 2024-10-01T12:19:07.000+03:00
Checking of NTFS_FLAGS_LOG_REPLAYING added to prevent access to
uninitialized bitmap during replay process.

Reported-by: syzbot+3bfd2cc059ab93efcdb4@syzkaller.appspotmail.com
Signed-off-by: Konstantin Komarov &lt;almaz.alexandrovich@paragon-software.com&gt;
diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
@@ -102,7 +102,9 @@ void ni_clear(struct ntfs_inode *ni)
 {
 	struct rb_node *node;
 
-	if (!ni->vfs_inode.i_nlink && ni->mi.mrec && is_rec_inuse(ni->mi.mrec))
+	if (!ni->vfs_inode.i_nlink && ni->mi.mrec &&
+	    is_rec_inuse(ni->mi.mrec) &&
+	    !(ni->mi.sbi->flags & NTFS_FLAGS_LOG_REPLAYING))
 		ni_delete_all(ni);
 
 	al_destroy(ni);

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,9 @@ void ni_clear(struct ntfs_inode *ni)`
`102`	`102`	`{`
`103`	`103`	`struct rb_node *node;`
`104`	`104`
`105`		`- if (!ni->vfs_inode.i_nlink && ni->mi.mrec && is_rec_inuse(ni->mi.mrec))`
	`105`	`+ if (!ni->vfs_inode.i_nlink && ni->mi.mrec &&`
	`106`	`+ is_rec_inuse(ni->mi.mrec) &&`
	`107`	`+ !(ni->mi.sbi->flags & NTFS_FLAGS_LOG_REPLAYING))`
`106`	`108`	`ni_delete_all(ni);`
`107`	`109`
`108`	`110`	`al_destroy(ni);`