Skip to content

Commit d21bc90

Browse files
marcanjannau
authored andcommitted
usb: typec: tipd: Be more verbose about errors
Make sure to print out error codes and log exactly what packet sizes were received in case of a mismatch. This is very useful for debugging badness. Signed-off-by: Hector Martin <marcan@marcan.st>
1 parent ee2af7b commit d21bc90

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

drivers/usb/typec/tipd/core.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,11 +175,15 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len)
175175
return regmap_raw_read(tps->regmap, reg, val, len);
176176

177177
ret = regmap_raw_read(tps->regmap, reg, data, len + 1);
178-
if (ret)
178+
if (ret) {
179+
dev_err(tps->dev, "regmap_raw_read returned %d\n", ret);
179180
return ret;
181+
}
180182

181-
if (data[0] < len)
183+
if (data[0] < len) {
184+
dev_err(tps->dev, "expected %zu bytes, got %d\n", len, data[0]);
182185
return -EIO;
186+
}
183187

184188
memcpy(val, &data[1], len);
185189
return 0;
@@ -474,7 +478,7 @@ static bool tps6598x_read_status(struct tps6598x *tps, u32 *status)
474478

475479
ret = tps6598x_read32(tps, TPS_REG_STATUS, status);
476480
if (ret) {
477-
dev_err(tps->dev, "%s: failed to read status\n", __func__);
481+
dev_err(tps->dev, "%s: failed to read status: %d\n", __func__, ret);
478482
return false;
479483
}
480484

0 commit comments

Comments
 (0)