Skip to content

Commit d347c9a

Browse files
Dan Carpentergregkh
authored andcommitted
drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq()
commit 6769a23 upstream. The "instance" variable needs to be signed for the error handling to work. Fixes: 8b2faf1 ("drm/amdgpu: add error handle to avoid out-of-bounds") Reviewed-by: Bob Zhou <bob.zhou@amd.com> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Cc: Siddh Raman Pant <siddh.raman.pant@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 73f3c33 commit d347c9a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2017,7 +2017,7 @@ static int sdma_v4_0_process_trap_irq(struct amdgpu_device *adev,
20172017
struct amdgpu_irq_src *source,
20182018
struct amdgpu_iv_entry *entry)
20192019
{
2020-
uint32_t instance;
2020+
int instance;
20212021

20222022
DRM_DEBUG("IH: SDMA trap\n");
20232023
instance = sdma_v4_0_irq_id_to_seq(entry->client_id);

0 commit comments

Comments
 (0)