gpio: shared: fix auxiliary device cleanup order

Bartosz Golaszewski · Bartosz Golaszewski · commit d382c765d083 · 2025-12-09T07:16:45.000+01:00
Dropping the last reference to the internal struct device should be the last thing we do so delete the device first and then uninit it which also involves the final put_device(). Fixes: a060b8c ("gpiolib: implement low-level, shared GPIO support") Link: https://lore.kernel.org/r/20251206-gpio-shared-teardown-fixes-v1-3-35ac458cfce1@oss.qualcomm.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
@@ -415,8 +415,8 @@ static void gpio_shared_remove_adev(struct auxiliary_device *adev)
 {
 	lockdep_assert_held(&gpio_shared_lock);
 
-	auxiliary_device_uninit(adev);
 	auxiliary_device_delete(adev);
+	auxiliary_device_uninit(adev);
 }
 
 int gpio_device_setup_shared(struct gpio_device *gdev)

Original file line number	Diff line number	Diff line change
`@@ -415,8 +415,8 @@ static void gpio_shared_remove_adev(struct auxiliary_device *adev)`
`415`	`415`	`{`
`416`	`416`	`lockdep_assert_held(&gpio_shared_lock);`
`417`	`417`
`418`		`- auxiliary_device_uninit(adev);`
`419`	`418`	`auxiliary_device_delete(adev);`
	`419`	`+ auxiliary_device_uninit(adev);`
`420`	`420`	`}`
`421`	`421`
`422`	`422`	`int gpio_device_setup_shared(struct gpio_device *gdev)`