Skip to content

Commit d3c4dde

Browse files
laura-naobebarino
authored andcommitted
clk: mediatek: clk-mux: Add ops for mux gates with set/clr/upd and FENC
MT8196 uses set/clr/upd registers for mux gate enable/disable control, along with a FENC bit to check the status. Add new set of mux gate clock operations with support for set/clr/upd and FENC status logic. Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> Signed-off-by: Laura Nao <laura.nao@collabora.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 2c327a1 commit d3c4dde

2 files changed

Lines changed: 94 additions & 0 deletions

File tree

drivers/clk/mediatek/clk-mux.c

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717

1818
#include "clk-mux.h"
1919

20+
#define MTK_WAIT_FENC_DONE_US 30
21+
2022
struct mtk_clk_mux {
2123
struct clk_hw hw;
2224
struct regmap *regmap;
@@ -30,6 +32,33 @@ static inline struct mtk_clk_mux *to_mtk_clk_mux(struct clk_hw *hw)
3032
return container_of(hw, struct mtk_clk_mux, hw);
3133
}
3234

35+
static int mtk_clk_mux_fenc_enable_setclr(struct clk_hw *hw)
36+
{
37+
struct mtk_clk_mux *mux = to_mtk_clk_mux(hw);
38+
unsigned long flags;
39+
u32 val;
40+
int ret;
41+
42+
if (mux->lock)
43+
spin_lock_irqsave(mux->lock, flags);
44+
else
45+
__acquire(mux->lock);
46+
47+
regmap_write(mux->regmap, mux->data->clr_ofs,
48+
BIT(mux->data->gate_shift));
49+
50+
ret = regmap_read_poll_timeout_atomic(mux->regmap, mux->data->fenc_sta_mon_ofs,
51+
val, val & BIT(mux->data->fenc_shift), 1,
52+
MTK_WAIT_FENC_DONE_US);
53+
54+
if (mux->lock)
55+
spin_unlock_irqrestore(mux->lock, flags);
56+
else
57+
__release(mux->lock);
58+
59+
return ret;
60+
}
61+
3362
static int mtk_clk_mux_enable_setclr(struct clk_hw *hw)
3463
{
3564
struct mtk_clk_mux *mux = to_mtk_clk_mux(hw);
@@ -70,6 +99,16 @@ static void mtk_clk_mux_disable_setclr(struct clk_hw *hw)
7099
BIT(mux->data->gate_shift));
71100
}
72101

102+
static int mtk_clk_mux_fenc_is_enabled(struct clk_hw *hw)
103+
{
104+
struct mtk_clk_mux *mux = to_mtk_clk_mux(hw);
105+
u32 val;
106+
107+
regmap_read(mux->regmap, mux->data->fenc_sta_mon_ofs, &val);
108+
109+
return !!(val & BIT(mux->data->fenc_shift));
110+
}
111+
73112
static int mtk_clk_mux_is_enabled(struct clk_hw *hw)
74113
{
75114
struct mtk_clk_mux *mux = to_mtk_clk_mux(hw);
@@ -166,6 +205,16 @@ const struct clk_ops mtk_mux_gate_clr_set_upd_ops = {
166205
};
167206
EXPORT_SYMBOL_GPL(mtk_mux_gate_clr_set_upd_ops);
168207

208+
const struct clk_ops mtk_mux_gate_fenc_clr_set_upd_ops = {
209+
.enable = mtk_clk_mux_fenc_enable_setclr,
210+
.disable = mtk_clk_mux_disable_setclr,
211+
.is_enabled = mtk_clk_mux_fenc_is_enabled,
212+
.get_parent = mtk_clk_mux_get_parent,
213+
.set_parent = mtk_clk_mux_set_parent_setclr_lock,
214+
.determine_rate = mtk_clk_mux_determine_rate,
215+
};
216+
EXPORT_SYMBOL_GPL(mtk_mux_gate_fenc_clr_set_upd_ops);
217+
169218
static struct clk_hw *mtk_clk_register_mux(struct device *dev,
170219
const struct mtk_mux *mux,
171220
struct regmap *regmap,

drivers/clk/mediatek/clk-mux.h

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,13 @@ struct mtk_mux {
2828
u32 set_ofs;
2929
u32 clr_ofs;
3030
u32 upd_ofs;
31+
u32 fenc_sta_mon_ofs;
3132

3233
u8 mux_shift;
3334
u8 mux_width;
3435
u8 gate_shift;
3536
s8 upd_shift;
37+
u8 fenc_shift;
3638

3739
const struct clk_ops *ops;
3840
signed char num_parents;
@@ -77,6 +79,7 @@ struct mtk_mux {
7779

7880
extern const struct clk_ops mtk_mux_clr_set_upd_ops;
7981
extern const struct clk_ops mtk_mux_gate_clr_set_upd_ops;
82+
extern const struct clk_ops mtk_mux_gate_fenc_clr_set_upd_ops;
8083

8184
#define MUX_GATE_CLR_SET_UPD_FLAGS(_id, _name, _parents, _mux_ofs, \
8285
_mux_set_ofs, _mux_clr_ofs, _shift, _width, \
@@ -118,6 +121,48 @@ extern const struct clk_ops mtk_mux_gate_clr_set_upd_ops;
118121
0, _upd_ofs, _upd, CLK_SET_RATE_PARENT, \
119122
mtk_mux_clr_set_upd_ops)
120123

124+
#define MUX_GATE_FENC_CLR_SET_UPD_FLAGS(_id, _name, _parents, _paridx, \
125+
_num_parents, _mux_ofs, _mux_set_ofs, _mux_clr_ofs, \
126+
_shift, _width, _gate, _upd_ofs, _upd, \
127+
_fenc_sta_mon_ofs, _fenc, _flags) { \
128+
.id = _id, \
129+
.name = _name, \
130+
.mux_ofs = _mux_ofs, \
131+
.set_ofs = _mux_set_ofs, \
132+
.clr_ofs = _mux_clr_ofs, \
133+
.upd_ofs = _upd_ofs, \
134+
.fenc_sta_mon_ofs = _fenc_sta_mon_ofs, \
135+
.mux_shift = _shift, \
136+
.mux_width = _width, \
137+
.gate_shift = _gate, \
138+
.upd_shift = _upd, \
139+
.fenc_shift = _fenc, \
140+
.parent_names = _parents, \
141+
.parent_index = _paridx, \
142+
.num_parents = _num_parents, \
143+
.flags = _flags, \
144+
.ops = &mtk_mux_gate_fenc_clr_set_upd_ops, \
145+
}
146+
147+
#define MUX_GATE_FENC_CLR_SET_UPD(_id, _name, _parents, \
148+
_mux_ofs, _mux_set_ofs, _mux_clr_ofs, \
149+
_shift, _width, _gate, _upd_ofs, _upd, \
150+
_fenc_sta_mon_ofs, _fenc) \
151+
MUX_GATE_FENC_CLR_SET_UPD_FLAGS(_id, _name, _parents, \
152+
NULL, ARRAY_SIZE(_parents), _mux_ofs, \
153+
_mux_set_ofs, _mux_clr_ofs, _shift, \
154+
_width, _gate, _upd_ofs, _upd, \
155+
_fenc_sta_mon_ofs, _fenc, 0)
156+
157+
#define MUX_GATE_FENC_CLR_SET_UPD_INDEXED(_id, _name, _parents, _paridx, \
158+
_mux_ofs, _mux_set_ofs, _mux_clr_ofs, \
159+
_shift, _width, _gate, _upd_ofs, _upd, \
160+
_fenc_sta_mon_ofs, _fenc) \
161+
MUX_GATE_FENC_CLR_SET_UPD_FLAGS(_id, _name, _parents, _paridx, \
162+
ARRAY_SIZE(_paridx), _mux_ofs, _mux_set_ofs, \
163+
_mux_clr_ofs, _shift, _width, _gate, _upd_ofs, _upd, \
164+
_fenc_sta_mon_ofs, _fenc, 0)
165+
121166
int mtk_clk_register_muxes(struct device *dev,
122167
const struct mtk_mux *muxes,
123168
int num, struct device_node *node,

0 commit comments

Comments
 (0)