Skip to content

Commit d3deabe

Browse files
author
Rob Clark
committed
drm/msm: Fix inverted WARN_ON() logic
We want to WARN_ON() if info is NULL. Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Fixes: 0838fc3 ("drm/msm/adreno: Check for recognized GPU before bind") Tested-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com> Reported-by: Alexey Klimov <alexey.klimov@linaro.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/658631/
1 parent 0838fc3 commit d3deabe

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/msm/adreno/adreno_device.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ static int adreno_bind(struct device *dev, struct device *master, void *data)
221221

222222
info = adreno_info(config.chip_id);
223223
/* We shouldn't have gotten this far if we don't recognize the GPU: */
224-
if (!WARN_ON(info))
224+
if (WARN_ON(!info))
225225
return -ENXIO;
226226

227227
config.info = info;

0 commit comments

Comments
 (0)