Skip to content

Commit d425aef

Browse files
moonlinuxmmind
authored andcommitted
arm64: dts: rockchip: Set correct pinctrl for I2S1 8ch TX on odroid-m1
Enable proper pin multiplexing for the I2S1 8-channel transmit interface by adding the default pinctrl configuration which esures correct signal routing and avoids pinmux conflicts during audio playback. Changes fix the error [ 116.856643] [ T782] rockchip-pinctrl pinctrl: pin gpio1-10 already requested by affinity_hint; cannot claim for fe410000.i2s [ 116.857567] [ T782] rockchip-pinctrl pinctrl: error -EINVAL: pin-42 (fe410000.i2s) [ 116.857618] [ T782] rockchip-pinctrl pinctrl: error -EINVAL: could not request pin 42 (gpio1-10) from group i2s1m0-sdi1 on device rockchip-pinctrl [ 116.857659] [ T782] rockchip-i2s-tdm fe410000.i2s: Error applying setting, reverse things back I2S1 on the M1 to the codec in the RK809 only uses the SCLK, LRCK, SDI0 and SDO0 signals, so limit the claimed pins to those. With this change audio output works as expected: $ aplay -l **** List of PLAYBACK Hardware Devices **** card 0: HDMI [HDMI], device 0: fe40000.i2s-i2s-hifi i2s-hifi-0 [fe40000.i2s-i2s-hifi i2s-hifi-0] Subdevices: 1/1 Subdevice #0: subdevice #0 card 1: RK817 [Analog RK817], device 0: fe410000.i2s-rk817-hifi rk817-hifi-0 [fe410000.i2s-rk817-hifi rk817-hifi-0] Subdevices: 1/1 Subdevice #0: subdevice #0 Fixes: 78f8584 ("arm64: dts: rockchip: Add analog audio on ODROID-M1") Cc: Aurelien Jarno <aurelien@aurel32.net> Signed-off-by: Anand Moon <linux.amoon@gmail.com> [adapted the commit message a bit] Signed-off-by: Heiko Stuebner <heiko@sntech.de>
1 parent 3a86608 commit d425aef

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -482,6 +482,8 @@
482482
};
483483

484484
&i2s1_8ch {
485+
pinctrl-names = "default";
486+
pinctrl-0 = <&i2s1m0_sclktx &i2s1m0_lrcktx &i2s1m0_sdi0 &i2s1m0_sdo0>;
485487
rockchip,trcm-sync-tx-only;
486488
status = "okay";
487489
};

0 commit comments

Comments
 (0)