Skip to content

Commit d49270a

Browse files
Weichen Chenkees
authored andcommitted
pstore/ram: Fix crash when setting number of cpus to an odd number
When the number of cpu cores is adjusted to 7 or other odd numbers, the zone size will become an odd number. The address of the zone will become: addr of zone0 = BASE addr of zone1 = BASE + zone_size addr of zone2 = BASE + zone_size*2 ... The address of zone1/3/5/7 will be mapped to non-alignment va. Eventually crashes will occur when accessing these va. So, use ALIGN_DOWN() to make sure the zone size is even to avoid this bug. Signed-off-by: Weichen Chen <weichen.chen@mediatek.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Tested-by: "Guilherme G. Piccoli" <gpiccoli@igalia.com> Link: https://lore.kernel.org/r/20230224023632.6840-1-weichen.chen@mediatek.com Signed-off-by: Kees Cook <keescook@chromium.org>
1 parent 98b1cc8 commit d49270a

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

fs/pstore/ram.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -529,6 +529,7 @@ static int ramoops_init_przs(const char *name,
529529
}
530530

531531
zone_sz = mem_sz / *cnt;
532+
zone_sz = ALIGN_DOWN(zone_sz, 2);
532533
if (!zone_sz) {
533534
dev_err(dev, "%s zone size == 0\n", name);
534535
goto fail;

0 commit comments

Comments
 (0)