dmaengine: idxd: Add missing idxd cleanup to fix memory leak in remove call

axiqia · vinodkoul · commit d5449ff1b04d · 2025-05-14T14:40:40.000+01:00
The remove call stack is missing idxd cleanup to free bitmap, ida and the idxd_device. Call idxd_free() helper routines to make sure we exit gracefully. Fixes: bfe1d56 ("dmaengine: idxd: Init and probe for Intel data accelerators") Cc: stable@vger.kernel.org Suggested-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com> Reviewed-by: Fenghua Yu <fenghuay@nvidia.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Link: https://lore.kernel.org/r/20250404120217.48772-9-xueshuai@linux.alibaba.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
@@ -1335,6 +1335,7 @@ static void idxd_remove(struct pci_dev *pdev)
 	destroy_workqueue(idxd->wq);
 	perfmon_pmu_remove(idxd);
 	put_device(idxd_confdev(idxd));
+	idxd_free(idxd);
 }
 
 static struct pci_driver idxd_pci_driver = {

Original file line number	Diff line number	Diff line change
`@@ -1335,6 +1335,7 @@ static void idxd_remove(struct pci_dev *pdev)`
`1335`	`1335`	`destroy_workqueue(idxd->wq);`
`1336`	`1336`	`perfmon_pmu_remove(idxd);`
`1337`	`1337`	`put_device(idxd_confdev(idxd));`
	`1338`	`+ idxd_free(idxd);`
`1338`	`1339`	`}`
`1339`	`1340`
`1340`	`1341`	`static struct pci_driver idxd_pci_driver = {`