Skip to content

Commit d5f6bd3

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: endpoint: pci-epf-test: Limit PCIe BAR size for fixed BARs
Currently, the test allocates BAR sizes according to fixed table bar_size. This does not work with controllers which have fixed size BARs that are smaller than the requested BAR size. One such controller is Renesas R-Car V4H PCIe controller, which has BAR4 size limited to 256 bytes, which is much less than one of the BAR size, 131072 currently requested by this test. A lot of controllers drivers in-tree have fixed size BARs, and they do work perfectly fine, but it is only because their fixed size is larger than the size requested by pci-epf-test.c Adjust the test such that in case a fixed size BAR is detected, the fixed BAR size is used, as that is the only possible option. This helps with test failures reported as follows: pci_epf_test pci_epf_test.0: requested BAR size is larger than fixed size pci_epf_test pci_epf_test.0: Failed to allocate space for BAR4 Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [mani: reworded description] Signed-off-by: Manivannan Sadhasivam <mani@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Niklas Cassel <cassel@kernel.org> Link: https://patch.msgid.link/20250905184240.144431-1-marek.vasut+renesas@mailbox.org
1 parent 106fc08 commit d5f6bd3

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

drivers/pci/endpoint/functions/pci-epf-test.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1050,7 +1050,12 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf)
10501050
if (bar == test_reg_bar)
10511051
continue;
10521052

1053-
base = pci_epf_alloc_space(epf, bar_size[bar], bar,
1053+
if (epc_features->bar[bar].type == BAR_FIXED)
1054+
test_reg_size = epc_features->bar[bar].fixed_size;
1055+
else
1056+
test_reg_size = bar_size[bar];
1057+
1058+
base = pci_epf_alloc_space(epf, test_reg_size, bar,
10541059
epc_features, PRIMARY_INTERFACE);
10551060
if (!base)
10561061
dev_err(dev, "Failed to allocate space for BAR%d\n",

0 commit comments

Comments
 (0)