Skip to content

Commit d68460b

Browse files
matttbekuba-moo
authored andcommitted
selftests: mptcp: join: mark 'flush re-add' as skipped if not supported
The call to 'continue_if' was missing: it properly marks a subtest as 'skipped' if the attached condition is not valid. Without that, the test is wrongly marked as passed on older kernels. Fixes: e06959e ("selftests: mptcp: join: test for flush/re-add endpoints") Cc: stable@vger.kernel.org Reviewed-by: Geliang Tang <geliang@kernel.org> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Link: https://patch.msgid.link/20251020-net-mptcp-c-flag-late-add-addr-v1-2-8207030cb0e8@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e84cb86 commit d68460b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4115,7 +4115,7 @@ endpoint_tests()
41154115

41164116
# flush and re-add
41174117
if reset_with_tcp_filter "flush re-add" ns2 10.0.3.2 REJECT OUTPUT &&
4118-
mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
4118+
continue_if mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
41194119
pm_nl_set_limits $ns1 0 2
41204120
pm_nl_set_limits $ns2 1 2
41214121
# broadcast IP: no packet for this address will be received on ns1

0 commit comments

Comments
 (0)