Skip to content

Commit d689863

Browse files
ubizjakingomolnar
authored andcommitted
x86/asm: Use %a instead of %P operand modifier in asm templates
The "P" asm operand modifier is a x86 target-specific modifier. For x86_64, when used with a symbol reference, the "%P" modifier emits "sym" instead of "sym(%rip)". This property is currently used to issue bare symbol reference. The generic "a" operand modifier should be used instead. The "a" asm operand modifier substitutes a memory reference, with the actual operand treated as address. For x86_64, when a symbol is provided, the "a" modifier emits "sym(%rip)" instead of "sym", enabling shorter %rip-relative addressing. Also note that unlike GCC, clang emits %rip-relative symbol reference with "P" asm operand modifier, so the patch also unifies symbol handling with both compilers. No functional changes intended. Signed-off-by: Uros Bizjak <ubizjak@gmail.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Ard Biesheuvel <ardb@kernel.org> Cc: "H. Peter Anvin" <hpa@zytor.com> Link: https://lore.kernel.org/r/20240319104418.284519-4-ubizjak@gmail.com
1 parent 41cd2e1 commit d689863

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/x86/include/asm/cpufeature.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ static __always_inline bool _static_cpu_has(u16 bit)
172172
ALTERNATIVE_TERNARY("jmp 6f", %c[feature], "", "jmp %l[t_no]")
173173
".pushsection .altinstr_aux,\"ax\"\n"
174174
"6:\n"
175-
" testb %[bitnum]," _ASM_RIP(%P[cap_byte]) "\n"
175+
" testb %[bitnum], %a[cap_byte]\n"
176176
" jnz %l[t_yes]\n"
177177
" jmp %l[t_no]\n"
178178
".popsection\n"

0 commit comments

Comments
 (0)