Skip to content

Commit d929e42

Browse files
committed
pmdomain: renesas: rcar-gen4-sysc: Don't keep unused PM domains powered-on
The recent changes to genpd makes a genpd OF provider that is powered-on at initialization to stay powered-on, until the ->sync_state() callback is invoked for it. This may not happen at all, if we wait for a consumer device to be probed, leading to wasting energy. There are ways to enforce the ->sync_state() callback to be invoked, through sysfs or via the probe-defer-timeout, but none of them in its current form are a good fit for rcar-gen4-sysc PM domains. Let's therefore opt-out from this behaviour of genpd for now, by using the GENPD_FLAG_NO_STAY_ON. Link: https://lore.kernel.org/all/20250701114733.636510-1-ulf.hansson@linaro.org/ Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Fixes: 0e789b4 ("pmdomain: core: Leave powered-on genpds on until sync_state") Fixes: 13a4b7f ("pmdomain: core: Leave powered-on genpds on until late_initcall_sync") Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 36bbaec commit d929e42

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/pmdomain/renesas/rcar-gen4-sysc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ static int __init rcar_gen4_sysc_pd_setup(struct rcar_gen4_sysc_pd *pd)
251251
genpd->detach_dev = cpg_mssr_detach_dev;
252252
}
253253

254+
genpd->flags |= GENPD_FLAG_NO_STAY_ON;
254255
genpd->power_off = rcar_gen4_sysc_pd_power_off;
255256
genpd->power_on = rcar_gen4_sysc_pd_power_on;
256257

0 commit comments

Comments
 (0)