Skip to content

Commit d963c95

Browse files
deribaucourtdavem330
authored andcommitted
net: dsa: microchip: use collision based back pressure mode
Errata DS80000758 states that carrier sense back pressure mode can cause link down issues in 100BASE-TX half duplex mode. The datasheet also recommends to always use the collision based back pressure mode. Fixes: b987e98 ("dsa: add DSA switch driver for Microchip KSZ9477") Signed-off-by: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@savoirfairelinux.com> Reviewed-by: Woojung Huh <Woojung.huh@microchip.com> Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 54a4e5c commit d963c95

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

drivers/net/dsa/microchip/ksz9477.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1297,6 +1297,10 @@ int ksz9477_setup(struct dsa_switch *ds)
12971297
/* Enable REG_SW_MTU__2 reg by setting SW_JUMBO_PACKET */
12981298
ksz_cfg(dev, REG_SW_MAC_CTRL_1, SW_JUMBO_PACKET, true);
12991299

1300+
/* Use collision based back pressure mode. */
1301+
ksz_cfg(dev, REG_SW_MAC_CTRL_1, SW_BACK_PRESSURE,
1302+
SW_BACK_PRESSURE_COLLISION);
1303+
13001304
/* Now we can configure default MTU value */
13011305
ret = regmap_update_bits(ksz_regmap_16(dev), REG_SW_MTU__2, REG_SW_MTU_MASK,
13021306
VLAN_ETH_FRAME_LEN + ETH_FCS_LEN);

drivers/net/dsa/microchip/ksz9477_reg.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,7 @@
247247
#define REG_SW_MAC_CTRL_1 0x0331
248248

249249
#define SW_BACK_PRESSURE BIT(5)
250+
#define SW_BACK_PRESSURE_COLLISION 0
250251
#define FAIR_FLOW_CTRL BIT(4)
251252
#define NO_EXC_COLLISION_DROP BIT(3)
252253
#define SW_JUMBO_PACKET BIT(2)

0 commit comments

Comments
 (0)