Skip to content

Commit da10577

Browse files
committed
drm: apple: Call dptxport_set_hpd in dcp_dptx_connect
Also increases the connection timeout to 2 seconds. Signed-off-by: Janne Grunau <j@jannau.net>
1 parent f93c267 commit da10577

1 file changed

Lines changed: 11 additions & 12 deletions

File tree

  • drivers/gpu/drm/apple

drivers/gpu/drm/apple/dcp.c

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ int dcp_get_connector_type(struct platform_device *pdev)
370370
}
371371
EXPORT_SYMBOL_GPL(dcp_get_connector_type);
372372

373-
#define DPTX_CONNECT_TIMEOUT msecs_to_jiffies(1000)
373+
#define DPTX_CONNECT_TIMEOUT msecs_to_jiffies(2000)
374374

375375
static int dcp_dptx_connect(struct apple_dcp *dcp, u32 port)
376376
{
@@ -410,24 +410,16 @@ static int dcp_dptx_connect(struct apple_dcp *dcp, u32 port)
410410

411411
usleep_range(5, 10);
412412

413+
if (dcp->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
414+
dptxport_set_hpd(dcp->dptxport[port].service, true);
415+
413416
return 0;
414417

415418
out_unlock:
416419
mutex_unlock(&dcp->hpd_mutex);
417420
return ret;
418421
}
419422

420-
int dcp_dptx_connect_oob(struct platform_device *pdev, u32 port)
421-
{
422-
struct apple_dcp *dcp = platform_get_drvdata(pdev);
423-
int err = dcp_dptx_connect(dcp, port);
424-
if (err < 0)
425-
return err;
426-
dptxport_set_hpd(dcp->dptxport[port].service, true);
427-
return 0;
428-
}
429-
EXPORT_SYMBOL_GPL(dcp_dptx_connect_oob);
430-
431423
static int dcp_dptx_disconnect(struct apple_dcp *dcp, u32 port)
432424
{
433425
dev_info(dcp->dev, "%s(port=%d)\n", __func__, port);
@@ -442,6 +434,13 @@ static int dcp_dptx_disconnect(struct apple_dcp *dcp, u32 port)
442434
return 0;
443435
}
444436

437+
int dcp_dptx_connect_oob(struct platform_device *pdev, u32 port)
438+
{
439+
struct apple_dcp *dcp = platform_get_drvdata(pdev);
440+
return dcp_dptx_connect(dcp, port);
441+
}
442+
EXPORT_SYMBOL_GPL(dcp_dptx_connect_oob);
443+
445444
int dcp_dptx_disconnect_oob(struct platform_device *pdev, u32 port)
446445
{
447446
struct apple_dcp *dcp = platform_get_drvdata(pdev);

0 commit comments

Comments
 (0)