Skip to content

Commit da93748

Browse files
Markus Burrijic23
authored andcommitted
iio: backend: fix out-of-bound write
The buffer is set to 80 character. If a caller write more characters, count is truncated to the max available space in "simple_write_to_buffer". But afterwards a string terminator is written to the buffer at offset count without boundary check. The zero termination is written OUT-OF-BOUND. Add a check that the given buffer is smaller then the buffer to prevent. Fixes: 035b498 ("iio: backend: make sure to NULL terminate stack buffer") Signed-off-by: Markus Burri <markus.burri@mt.com> Reviewed-by: Nuno Sá <nuno.sa@analog.com> Link: https://patch.msgid.link/20250508130612.82270-2-markus.burri@mt.com Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
1 parent 19272b3 commit da93748

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

drivers/iio/industrialio-backend.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,14 @@ static ssize_t iio_backend_debugfs_write_reg(struct file *file,
155155
ssize_t rc;
156156
int ret;
157157

158+
if (count >= sizeof(buf))
159+
return -ENOSPC;
160+
158161
rc = simple_write_to_buffer(buf, sizeof(buf) - 1, ppos, userbuf, count);
159162
if (rc < 0)
160163
return rc;
161164

162-
buf[count] = '\0';
165+
buf[rc] = '\0';
163166

164167
ret = sscanf(buf, "%i %i", &back->cached_reg_addr, &val);
165168

0 commit comments

Comments
 (0)