Skip to content

Commit dacfd00

Browse files
TaylorJ-406brauner
authored andcommitted
fs/mnt_idmapping.c: Return -EINVAL when no map is written
Currently, it is possible to create an idmapped mount using a user namespace without any mappings. However, this yields an idmapped mount that doesn't actually map the ids. With the following change, it will no longer be possible to create an idmapped mount when using a user namespace with no mappings, and will instead return EINVAL, an “invalid argument” error code. Reviewed-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Taylor Jackson <taylor.a.jackson@me.com> Link: https://lore.kernel.org/r/20240208-mnt-idmap-inval-v2-1-58ef26d194e0@me.com Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent d31563b commit dacfd00

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/mnt_idmapping.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ static int copy_mnt_idmap(struct uid_gid_map *map_from,
214214
* anything at all.
215215
*/
216216
if (nr_extents == 0)
217-
return 0;
217+
return -EINVAL;
218218

219219
/*
220220
* Here we know that nr_extents is greater than zero which means

0 commit comments

Comments
 (0)