Skip to content

Commit daf0b99

Browse files
Amadeusz Sławińskibroonie
authored andcommitted
ASoC: topology: Do not assign fields that are already set
The routes are allocated with kzalloc(), so all fields are zeroed by default, skip unnecessary assignments. Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-4-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent fd660b1 commit daf0b99

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

sound/soc/soc-topology.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1072,11 +1072,7 @@ static int soc_tplg_dapm_graph_elems_load(struct soc_tplg *tplg,
10721072
break;
10731073
}
10741074

1075-
/* set to NULL atm for tplg users */
1076-
route->connected = NULL;
1077-
if (strnlen(elem->control, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) == 0) {
1078-
route->control = NULL;
1079-
} else {
1075+
if (strnlen(elem->control, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) != 0) {
10801076
route->control = devm_kmemdup(tplg->dev, elem->control,
10811077
min(strlen(elem->control),
10821078
SNDRV_CTL_ELEM_ID_NAME_MAXLEN),

0 commit comments

Comments
 (0)