erofs: fix potential return value overflow of z_erofs_shrink_scan()

hsiangkao · hsiangkao · commit db902986dee4 · 2025-01-17T03:19:39.000+08:00
z_erofs_shrink_scan() could return small numbers due to the mistyped `freed`. Although I don't think it has any visible impact. Fixes: 3883a79 ("staging: erofs: introduce VLE decompression support") Reviewed-by: Chao Yu <chao@kernel.org> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> Link: https://lore.kernel.org/r/20250114040058.459981-1-hsiangkao@linux.alibaba.com
diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
@@ -927,8 +927,7 @@ unsigned long z_erofs_shrink_scan(struct erofs_sb_info *sbi,
 				  unsigned long nr_shrink)
 {
 	struct z_erofs_pcluster *pcl;
-	unsigned int freed = 0;
-	unsigned long index;
+	unsigned long index, freed = 0;
 
 	xa_lock(&sbi->managed_pslots);
 	xa_for_each(&sbi->managed_pslots, index, pcl) {

Original file line number	Diff line number	Diff line change
`@@ -927,8 +927,7 @@ unsigned long z_erofs_shrink_scan(struct erofs_sb_info *sbi,`
`927`	`927`	`unsigned long nr_shrink)`
`928`	`928`	`{`
`929`	`929`	`struct z_erofs_pcluster *pcl;`
`930`		`- unsigned int freed = 0;`
`931`		`- unsigned long index;`
	`930`	`+ unsigned long index, freed = 0;`
`932`	`931`
`933`	`932`	`xa_lock(&sbi->managed_pslots);`
`934`	`933`	`xa_for_each(&sbi->managed_pslots, index, pcl) {`