Skip to content

Commit dc604b4

Browse files
quic-cangmartinkpetersen
authored andcommitted
scsi: ufs: ufs-qcom: No need to set hs_rate after ufshcd_init_host_param()
In ufs_qcom_pwr_change_notify(), host_params.hs_rate has been set to PA_HS_MODE_B by ufshcd_init_host_param(), hence remove the duplicated line of work. Meanwhile, removed the macro UFS_QCOM_LIMIT_HS_RATE as it is only used here. Reviewed-by: Nitin Rawat <quic_nitirawa@quicinc.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Andrew Halaney <ahalaney@redhat.com> Signed-off-by: Can Guo <quic_cang@quicinc.com> Link: https://lore.kernel.org/r/1701520577-31163-3-git-send-email-quic_cang@quicinc.com Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent fa3dca8 commit dc604b4

2 files changed

Lines changed: 0 additions & 3 deletions

File tree

drivers/ufs/host/ufs-qcom.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -909,7 +909,6 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba,
909909
switch (status) {
910910
case PRE_CHANGE:
911911
ufshcd_init_host_params(&host_params);
912-
host_params.hs_rate = UFS_QCOM_LIMIT_HS_RATE;
913912

914913
/* This driver only supports symmetic gear setting i.e., hs_tx_gear == hs_rx_gear */
915914
host_params.hs_tx_gear = host_params.hs_rx_gear = ufs_qcom_get_hs_gear(hba);

drivers/ufs/host/ufs-qcom.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727
#define SLOW 1
2828
#define FAST 2
2929

30-
#define UFS_QCOM_LIMIT_HS_RATE PA_HS_MODE_B
31-
3230
/* QCOM UFS host controller vendor specific registers */
3331
enum {
3432
REG_UFS_SYS1CLK_1US = 0xC0,

0 commit comments

Comments
 (0)