Skip to content

Commit dc80c79

Browse files
committed
drm: apple: dptx: Fix get_drive_settings retcode
This appears to be lane count as "2" is observed for USB-C DP alt mode in shared DP/USB3 mode. Signed-off-by: Janne Grunau <j@jannau.net>
1 parent 6c87f69 commit dc80c79

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

drivers/gpu/drm/apple/dptxep.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,12 +189,16 @@ dptxport_call_get_drive_settings(struct apple_epic_service *service,
189189
/* Clear the rest of the buffer */
190190
memset(reply_ + sizeof(*reply), 0, reply_size - sizeof(*reply));
191191

192-
if (reply->retcode != 4)
192+
/*
193+
* retcode appears to be lane count, seeing 2 for USB-C dp alt mode
194+
* with lanes splitted for DP/USB3.
195+
*/
196+
if (reply->retcode != dptx->lane_count)
193197
dev_err(service->ep->dcp->dev,
194198
"get_drive_settings: unexpected retcode %d\n",
195199
reply->retcode);
196200

197-
reply->retcode = 4; /* Should already be 4? */
201+
reply->retcode = dptx->lane_count;
198202
reply->unk5 = dptx->drive_settings[0];
199203
reply->unk6 = 0;
200204
reply->unk7 = dptx->drive_settings[1];

0 commit comments

Comments
 (0)