Skip to content

Commit dce043c

Browse files
eugkoirajoergroedel
authored andcommitted
iommu/vt-d: Fix __domain_mapping()'s usage of switch_to_super_page()
switch_to_super_page() assumes the memory range it's working on is aligned to the target large page level. Unfortunately, __domain_mapping() doesn't take this into account when using it, and will pass unaligned ranges ultimately freeing a PTE range larger than expected. Take for example a mapping with the following iov_pfn range [0x3fe400, 0x4c0600), which should be backed by the following mappings: iov_pfn [0x3fe400, 0x3fffff] covered by 2MiB pages iov_pfn [0x400000, 0x4bffff] covered by 1GiB pages iov_pfn [0x4c0000, 0x4c05ff] covered by 2MiB pages Under this circumstance, __domain_mapping() will pass [0x400000, 0x4c05ff] to switch_to_super_page() at a 1 GiB granularity, which will in turn free PTEs all the way to iov_pfn 0x4fffff. Mitigate this by rounding down the iov_pfn range passed to switch_to_super_page() in __domain_mapping() to the target large page level. Additionally add range alignment checks to switch_to_super_page. Fixes: 9906b93 ("iommu/vt-d: Avoid duplicate removing in __domain_mapping()") Signed-off-by: Eugene Koira <eugkoira@amazon.com> Cc: stable@vger.kernel.org Reviewed-by: Nicolas Saenz Julienne <nsaenz@amazon.com> Reviewed-by: David Woodhouse <dwmw@amazon.co.uk> Link: https://lore.kernel.org/r/20250826143816.38686-1-eugkoira@amazon.com Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
1 parent b3506e9 commit dce043c

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

drivers/iommu/intel/iommu.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1575,6 +1575,10 @@ static void switch_to_super_page(struct dmar_domain *domain,
15751575
unsigned long lvl_pages = lvl_to_nr_pages(level);
15761576
struct dma_pte *pte = NULL;
15771577

1578+
if (WARN_ON(!IS_ALIGNED(start_pfn, lvl_pages) ||
1579+
!IS_ALIGNED(end_pfn + 1, lvl_pages)))
1580+
return;
1581+
15781582
while (start_pfn <= end_pfn) {
15791583
if (!pte)
15801584
pte = pfn_to_dma_pte(domain, start_pfn, &level,
@@ -1650,7 +1654,8 @@ __domain_mapping(struct dmar_domain *domain, unsigned long iov_pfn,
16501654
unsigned long pages_to_remove;
16511655

16521656
pteval |= DMA_PTE_LARGE_PAGE;
1653-
pages_to_remove = min_t(unsigned long, nr_pages,
1657+
pages_to_remove = min_t(unsigned long,
1658+
round_down(nr_pages, lvl_pages),
16541659
nr_pte_to_next_page(pte) * lvl_pages);
16551660
end_pfn = iov_pfn + pages_to_remove - 1;
16561661
switch_to_super_page(domain, iov_pfn, end_pfn, largepage_lvl);

0 commit comments

Comments
 (0)