Skip to content

Commit dd3feaf

Browse files
ytcooderobherring
authored andcommitted
of/reserved_mem: Simplify the logic of __reserved_mem_alloc_size()
Use the existing helper functions to simplify the logic of __reserved_mem_alloc_size() Signed-off-by: Yuntao Wang <yuntao.wang@linux.dev> Link: https://patch.msgid.link/20251115134753.179931-9-yuntao.wang@linux.dev Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
1 parent 85a8a30 commit dd3feaf

1 file changed

Lines changed: 7 additions & 14 deletions

File tree

drivers/of/of_reserved_mem.c

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -385,10 +385,9 @@ static int __init __reserved_mem_alloc_in_range(phys_addr_t size,
385385
*/
386386
static int __init __reserved_mem_alloc_size(unsigned long node, const char *uname)
387387
{
388-
int t_len = (dt_root_addr_cells + dt_root_size_cells) * sizeof(__be32);
389388
phys_addr_t start = 0, end = 0;
390389
phys_addr_t base = 0, align = 0, size;
391-
int len;
390+
int i, len;
392391
const __be32 *prop;
393392
bool nomap;
394393
int ret;
@@ -422,19 +421,15 @@ static int __init __reserved_mem_alloc_size(unsigned long node, const char *unam
422421
&& !nomap)
423422
align = max_t(phys_addr_t, align, CMA_MIN_ALIGNMENT_BYTES);
424423

425-
prop = of_get_flat_dt_prop(node, "alloc-ranges", &len);
424+
prop = of_flat_dt_get_addr_size_prop(node, "alloc-ranges", &len);
426425
if (prop) {
426+
for (i = 0; i < len; i++) {
427+
u64 b, s;
427428

428-
if (len % t_len != 0) {
429-
pr_err("invalid alloc-ranges property in '%s', skipping node.\n",
430-
uname);
431-
return -EINVAL;
432-
}
429+
of_flat_dt_read_addr_size(prop, i, &b, &s);
433430

434-
while (len > 0) {
435-
start = dt_mem_next_cell(dt_root_addr_cells, &prop);
436-
end = start + dt_mem_next_cell(dt_root_size_cells,
437-
&prop);
431+
start = b;
432+
end = b + s;
438433

439434
base = 0;
440435
ret = __reserved_mem_alloc_in_range(size, align,
@@ -445,9 +440,7 @@ static int __init __reserved_mem_alloc_size(unsigned long node, const char *unam
445440
(unsigned long)(size / SZ_1M));
446441
break;
447442
}
448-
len -= t_len;
449443
}
450-
451444
} else {
452445
ret = early_init_dt_alloc_reserved_memory_arch(size, align,
453446
0, 0, nomap, &base);

0 commit comments

Comments
 (0)