Skip to content

Commit ddb61e7

Browse files
Wer-Wolfgroeck
authored andcommitted
hwmon: (dell-smm) Remove Dell Precision 490 custom config data
It turns out the second fan on the Dell Precision 490 does not really support I8K_FAN_TURBO. Setting the fan state to 3 enables automatic fan control, just like on the other two fans. The reason why this was misinterpreted as turbo mode was that the second fan normally spins faster in automatic mode than in the previous fan states. Yet when in state 3, the fan speed reacts to heat exposure, exposing the automatic mode setting. Link: lm-sensors/lm-sensors#383 Signed-off-by: Armin Wolf <W_Armin@gmx.de> Link: https://lore.kernel.org/r/20250917181036.10972-2-W_Armin@gmx.de Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 5d5ec7c commit ddb61e7

1 file changed

Lines changed: 0 additions & 14 deletions

File tree

drivers/hwmon/dell-smm-hwmon.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1331,7 +1331,6 @@ struct i8k_config_data {
13311331

13321332
enum i8k_configs {
13331333
DELL_LATITUDE_D520,
1334-
DELL_PRECISION_490,
13351334
DELL_STUDIO,
13361335
DELL_XPS,
13371336
};
@@ -1341,10 +1340,6 @@ static const struct i8k_config_data i8k_config_data[] __initconst = {
13411340
.fan_mult = 1,
13421341
.fan_max = I8K_FAN_TURBO,
13431342
},
1344-
[DELL_PRECISION_490] = {
1345-
.fan_mult = 1,
1346-
.fan_max = I8K_FAN_TURBO,
1347-
},
13481343
[DELL_STUDIO] = {
13491344
.fan_mult = 1,
13501345
.fan_max = I8K_FAN_HIGH,
@@ -1364,15 +1359,6 @@ static const struct dmi_system_id i8k_config_dmi_table[] __initconst = {
13641359
},
13651360
.driver_data = (void *)&i8k_config_data[DELL_LATITUDE_D520],
13661361
},
1367-
{
1368-
.ident = "Dell Precision 490",
1369-
.matches = {
1370-
DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
1371-
DMI_MATCH(DMI_PRODUCT_NAME,
1372-
"Precision WorkStation 490"),
1373-
},
1374-
.driver_data = (void *)&i8k_config_data[DELL_PRECISION_490],
1375-
},
13761362
{
13771363
.ident = "Dell Studio",
13781364
.matches = {

0 commit comments

Comments
 (0)