media: apple: isp: Make sub-pmdomain handling explicit

Signed-off-by: Asahi Lina <lina@asahilina.net>

Author: hoshinolina

drivers/media/platform/apple/isp/isp-drv.c

@@ -54,16 +54,21 @@ static int apple_isp_attach_genpd(struct apple_isp *isp)
 		return -ENOMEM;
 
 	for (int i = 0; i < isp->pd_count; i++) {
+		int flags = DL_FLAG_STATELESS;
+
+		/* Primary power domain uses RPM integration */
+		if (i == 0)
+			flags |= DL_FLAG_PM_RUNTIME | DL_FLAG_RPM_ACTIVE;
+
 		isp->pd_dev[i] = dev_pm_domain_attach_by_id(dev, i);
 		if (IS_ERR(isp->pd_dev[i])) {
 			apple_isp_detach_genpd(isp);
 			return PTR_ERR(isp->pd_dev[i]);
 		}
 
 		isp->pd_link[i] =
-			device_link_add(dev, isp->pd_dev[i],
-					DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME |
-						DL_FLAG_RPM_ACTIVE);
+			device_link_add(dev, isp->pd_dev[i], flags);
+
 		if (!isp->pd_link[i]) {
 			apple_isp_detach_genpd(isp);
 			return -EINVAL;

drivers/media/platform/apple/isp/isp-drv.h

@@ -198,6 +198,7 @@ struct apple_isp {
 	int pd_count;
 	struct device **pd_dev;
 	struct device_link **pd_link;
+	bool pds_active;
 
 	int irq;
 

drivers/media/platform/apple/isp/isp-fw.c

@@ -39,6 +39,46 @@ static inline void isp_gpio_write32(struct apple_isp *isp, u32 reg, u32 val)
 	writel(val, isp->gpio + reg);
 }
 
+int apple_isp_power_up_domains(struct apple_isp *isp)
+{
+	int ret;
+
+	if (isp->pds_active)
+		return 0;
+
+	for (int i = 1; i < isp->pd_count; i++) {
+		ret = pm_runtime_get_sync(isp->pd_dev[i]);
+		if (ret < 0) {
+			dev_err(isp->dev,
+				"Failed to power up power domain %d: %d\n", i, ret);
+			while (--i != 1)
+				pm_runtime_put_sync(isp->pd_dev[i]);
+			return ret;
+		}
+	}
+
+	isp->pds_active = true;
+
+	return 0;
+}
+
+void apple_isp_power_down_domains(struct apple_isp *isp)
+{
+	int ret;
+
+	if (!isp->pds_active)
+		return;
+
+	for (int i = isp->pd_count - 1; i >= 1; i--) {
+		ret = pm_runtime_put_sync(isp->pd_dev[i]);
+		if (ret < 0)
+			dev_err(isp->dev,
+				"Failed to power up power domain %d: %d\n", i, ret);
+	}
+
+	isp->pds_active = false;
+}
+
 void *apple_isp_translate(struct apple_isp *isp, struct isp_surf *surf,
 			  dma_addr_t iova, size_t size)
 {
@@ -207,11 +247,16 @@ static int isp_reset_coproc(struct apple_isp *isp)
 static void isp_firmware_shutdown_stage1(struct apple_isp *isp)
 {
 	isp_coproc_write32(isp, ISP_COPROC_CONTROL, 0x0);
+
+	apple_isp_power_down_domains(isp);
 }
 
 static int isp_firmware_boot_stage1(struct apple_isp *isp)
 {
 	int err, retries;
+	err = apple_isp_power_up_domains(isp);
+	if (err < 0)
+		return err;
 
 	err = isp_reset_coproc(isp);
 	if (err < 0)