Skip to content

Commit defdf27

Browse files
committed
drm/xe/forcewake: Improve kerneldoc
Improve the kerneldoc for forcewake a bit to give more detail about what the structures represent. Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com> Reviewed-by: Stuart Summers <stuart.summers@intel.com> Link: https://patch.msgid.link/20251110232017.1475869-33-matthew.d.roper@intel.com Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
1 parent e448372 commit defdf27

1 file changed

Lines changed: 24 additions & 2 deletions

File tree

drivers/gpu/drm/xe/xe_force_wake_types.h

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,22 @@ enum xe_force_wake_domains {
5252
};
5353

5454
/**
55-
* struct xe_force_wake_domain - Xe force wake domains
55+
* struct xe_force_wake_domain - Xe force wake power domain
56+
*
57+
* Represents an individual device-internal power domain. The driver must
58+
* ensure the power domain is awake before accessing registers or other
59+
* hardware functionality that is part of the power domain. Since different
60+
* driver threads may access hardware units simultaneously, a reference count
61+
* is used to ensure that the domain remains awake as long as any software
62+
* is using the part of the hardware covered by the power domain.
63+
*
64+
* Hardware provides a register interface to allow the driver to request
65+
* wake/sleep of power domains, although in most cases the actual action of
66+
* powering the hardware up/down is handled by firmware (and may be subject to
67+
* requirements and constraints outside of the driver's visibility) so the
68+
* driver needs to wait for an acknowledgment that a wake request has been
69+
* acted upon before accessing the parts of the hardware that reside within the
70+
* power domain.
5671
*/
5772
struct xe_force_wake_domain {
5873
/** @id: domain force wake id */
@@ -70,7 +85,14 @@ struct xe_force_wake_domain {
7085
};
7186

7287
/**
73-
* struct xe_force_wake - Xe force wake
88+
* struct xe_force_wake - Xe force wake collection
89+
*
90+
* Represents a collection of related power domains (struct
91+
* xe_force_wake_domain) associated with a subunit of the device.
92+
*
93+
* Currently only used for GT power domains (where the term "forcewake" is used
94+
* in the hardware documentation), although the interface could be extended to
95+
* power wells in other parts of the hardware in the future.
7496
*/
7597
struct xe_force_wake {
7698
/** @gt: back pointers to GT */

0 commit comments

Comments
 (0)