Skip to content

Commit dfe9707

Browse files
srishanmalexdeucher
authored andcommitted
drm/amd/display: Fix misuse of /** to /* in 'dce_i2c_hw.c'
Fix the comment style before cntl_stuck_hw_workaround() by replacing '/**' with '/*' since it is not a kdoc comment. Fixes the below with gcc W=1: display/dc/dce/dce_i2c_hw.c:380: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * If we boot without an HDMI display, the I2C engine does not get initialized Fixes: 04d57f4 ("drm/amd/display: Workaround for stuck I2C arbitrage") Cc: Alvin Lee <alvin.lee2@amd.com> Cc: Dominik Kaszewski <dominik.kaszewski@amd.com> Cc: Ivan Lipski <ivan.lipski@amd.com> Cc: Harry Wentland <harry.wentland@amd.com> Cc: Tom Chung <chiahsuan.chung@amd.com> Cc: Roman Li <roman.li@amd.com> Cc: Alex Hung <alex.hung@amd.com> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com> Reviewed-by: Alex Hung <alex.hung@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 9c28830 commit dfe9707

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,10 +377,16 @@ static bool setup_engine(
377377
}
378378

379379
/**
380+
* cntl_stuck_hw_workaround - Workaround for I2C engine stuck state
381+
* @dce_i2c_hw: Pointer to dce_i2c_hw structure
382+
*
380383
* If we boot without an HDMI display, the I2C engine does not get initialized
381384
* correctly. One of its symptoms is that SW_USE_I2C does not get cleared after
382-
* acquire, so that after setting SW_DONE_USING_I2C on release, the engine gets
385+
* acquire. After setting SW_DONE_USING_I2C on release, the engine gets
383386
* immediately reacquired by SW, preventing DMUB from using it.
387+
*
388+
* This function checks the I2C arbitration status and applies a release
389+
* workaround if necessary.
384390
*/
385391
static void cntl_stuck_hw_workaround(struct dce_i2c_hw *dce_i2c_hw)
386392
{

0 commit comments

Comments
 (0)