hv_sock: Initializing vsk->trans to NULL to prevent a dangling pointer

ImV4bel · gregkh · commit e0fe33923712 · 2024-11-14T13:21:16.000+01:00
commit e629295 upstream. When hvs is released, there is a possibility that vsk->trans may not be initialized to NULL, which could lead to a dangling pointer. This issue is resolved by initializing vsk->trans to NULL. Signed-off-by: Hyunwoo Kim <v4bel@theori.io> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Link: https://patch.msgid.link/Zys4hCj61V+mQfX2@v4bel-B760M-AORUS-ELITE-AX Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c
@@ -549,6 +549,7 @@ static void hvs_destruct(struct vsock_sock *vsk)
 		vmbus_hvsock_device_unregister(chan);
 
 	kfree(hvs);
+	vsk->trans = NULL;
 }
 
 static int hvs_dgram_bind(struct vsock_sock *vsk, struct sockaddr_vm *addr)

Original file line number	Diff line number	Diff line change
`@@ -549,6 +549,7 @@ static void hvs_destruct(struct vsock_sock *vsk)`
`549`	`549`	`vmbus_hvsock_device_unregister(chan);`
`550`	`550`
`551`	`551`	`kfree(hvs);`
	`552`	`+ vsk->trans = NULL;`
`552`	`553`	`}`
`553`	`554`
`554`	`555`	`static int hvs_dgram_bind(struct vsock_sock vsk, struct sockaddr_vm addr)`