vdpa/octeon_ep: Fix error code in octep_process_mbox()

Dan Carpenter · mstsirkin · commit e14f480df7fb · 2024-07-17T05:43:20.000-04:00
Return -EINVAL for invalid signatures. Don't return success. Fixes: 8b6c724 ("virtio: vdpa: vDPA driver for Marvell OCTEON DPU devices") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Message-Id: <623e885b-1a05-479e-ab97-01bcf10bf5b8@stanley.mountain> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
@@ -140,7 +140,7 @@ static int octep_process_mbox(struct octep_hw *oct_hw, u16 id, u16 qid, void *bu
 	val = octep_read_sig(mbox);
 	if ((val & 0xFFFF) != MBOX_RSP_SIG) {
 		dev_warn(&pdev->dev, "Invalid Signature from mbox : %d response\n", id);
-		return ret;
+		return -EINVAL;
 	}
 
 	val = octep_read_sts(mbox);

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ static int octep_process_mbox(struct octep_hw oct_hw, u16 id, u16 qid, void bu`
`140`	`140`	`val = octep_read_sig(mbox);`
`141`	`141`	`if ((val & 0xFFFF) != MBOX_RSP_SIG) {`
`142`	`142`	`dev_warn(&pdev->dev, "Invalid Signature from mbox : %d response\n", id);`
`143`		`- return ret;`
	`143`	`+ return -EINVAL;`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`val = octep_read_sts(mbox);`