Skip to content

Commit e1533b6

Browse files
abajkkuba-moo
authored andcommitted
net: ethernet: lantiq_etop: fix double free in detach
The number of the currently released descriptor is never incremented which results in the same skb being released multiple times. Fixes: 504d472 ("MIPS: Lantiq: Add ethernet driver") Reported-by: Joe Perches <joe@perches.com> Closes: https://lore.kernel.org/all/fc1bf93d92bb5b2f99c6c62745507cc22f3a7b2d.camel@perches.com/ Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://patch.msgid.link/20240708205826.5176-1-olek2@wp.pl Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 01fc514 commit e1533b6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/net/ethernet/lantiq_etop.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,9 +217,9 @@ ltq_etop_free_channel(struct net_device *dev, struct ltq_etop_chan *ch)
217217
if (ch->dma.irq)
218218
free_irq(ch->dma.irq, priv);
219219
if (IS_RX(ch->idx)) {
220-
int desc;
220+
struct ltq_dma_channel *dma = &ch->dma;
221221

222-
for (desc = 0; desc < LTQ_DESC_NUM; desc++)
222+
for (dma->desc = 0; dma->desc < LTQ_DESC_NUM; dma->desc++)
223223
dev_kfree_skb_any(ch->skb[ch->dma.desc]);
224224
}
225225
}

0 commit comments

Comments
 (0)