Skip to content

Commit e1714f3

Browse files
starnightkwilczynski
authored andcommitted
PCI/ASPM: Add notes about enabling PCI-PM L1SS to pci_enable_link_state(_locked)
According to "PCIe r6.0, sec 5.5.4", add note about D0 requirement in pci_enable_link_state() kernel-doc. Link: https://lore.kernel.org/r/20241001083438.10070-6-jhp@endlessos.org Signed-off-by: Jian-Hong Pan <jhp@endlessos.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
1 parent 7447990 commit e1714f3

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

drivers/pci/pcie/aspm.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1450,6 +1450,9 @@ static int __pci_enable_link_state(struct pci_dev *pdev, int state, bool locked)
14501450
* touch the LNKCTL register. Also note that this does not enable states
14511451
* disabled by pci_disable_link_state(). Return 0 or a negative errno.
14521452
*
1453+
* Note: Ensure devices are in D0 before enabling PCI-PM L1 PM Substates, per
1454+
* PCIe r6.0, sec 5.5.4.
1455+
*
14531456
* @pdev: PCI device
14541457
* @state: Mask of ASPM link states to enable
14551458
*/
@@ -1466,6 +1469,9 @@ EXPORT_SYMBOL(pci_enable_link_state);
14661469
* can't touch the LNKCTL register. Also note that this does not enable states
14671470
* disabled by pci_disable_link_state(). Return 0 or a negative errno.
14681471
*
1472+
* Note: Ensure devices are in D0 before enabling PCI-PM L1 PM Substates, per
1473+
* PCIe r6.0, sec 5.5.4.
1474+
*
14691475
* @pdev: PCI device
14701476
* @state: Mask of ASPM link states to enable
14711477
*

0 commit comments

Comments
 (0)