Skip to content

Commit e19e1ab

Browse files
Wolfram Sangwsakernel
authored andcommitted
i2c: npcm7xx: move to per-adapter debugfs directory
The I2C core now provides a per-adapter debugfs directory. Use it instead of creating a custom one. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Tali Perry <tali.perry1@gmail.com> Signed-off-by: Wolfram Sang <wsa@kernel.org>
1 parent c66520c commit e19e1ab

1 file changed

Lines changed: 7 additions & 42 deletions

File tree

drivers/i2c/busses/i2c-npcm7xx.c

Lines changed: 7 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,6 @@ struct npcm_i2c {
326326
u8 slv_rd_buf[MAX_I2C_HW_FIFO_SIZE];
327327
u8 slv_wr_buf[MAX_I2C_HW_FIFO_SIZE];
328328
#endif
329-
struct dentry *debugfs; /* debugfs device directory */
330329
u64 ber_cnt;
331330
u64 rec_succ_cnt;
332331
u64 rec_fail_cnt;
@@ -2250,27 +2249,15 @@ static const struct i2c_algorithm npcm_i2c_algo = {
22502249
#endif
22512250
};
22522251

2253-
/* i2c debugfs directory: used to keep health monitor of i2c devices */
2254-
static struct dentry *npcm_i2c_debugfs_dir;
2255-
22562252
static void npcm_i2c_init_debugfs(struct platform_device *pdev,
22572253
struct npcm_i2c *bus)
22582254
{
2259-
struct dentry *d;
2260-
2261-
if (!npcm_i2c_debugfs_dir)
2262-
return;
2263-
d = debugfs_create_dir(dev_name(&pdev->dev), npcm_i2c_debugfs_dir);
2264-
if (IS_ERR_OR_NULL(d))
2265-
return;
2266-
debugfs_create_u64("ber_cnt", 0444, d, &bus->ber_cnt);
2267-
debugfs_create_u64("nack_cnt", 0444, d, &bus->nack_cnt);
2268-
debugfs_create_u64("rec_succ_cnt", 0444, d, &bus->rec_succ_cnt);
2269-
debugfs_create_u64("rec_fail_cnt", 0444, d, &bus->rec_fail_cnt);
2270-
debugfs_create_u64("timeout_cnt", 0444, d, &bus->timeout_cnt);
2271-
debugfs_create_u64("tx_complete_cnt", 0444, d, &bus->tx_complete_cnt);
2272-
2273-
bus->debugfs = d;
2255+
debugfs_create_u64("ber_cnt", 0444, bus->adap.debugfs, &bus->ber_cnt);
2256+
debugfs_create_u64("nack_cnt", 0444, bus->adap.debugfs, &bus->nack_cnt);
2257+
debugfs_create_u64("rec_succ_cnt", 0444, bus->adap.debugfs, &bus->rec_succ_cnt);
2258+
debugfs_create_u64("rec_fail_cnt", 0444, bus->adap.debugfs, &bus->rec_fail_cnt);
2259+
debugfs_create_u64("timeout_cnt", 0444, bus->adap.debugfs, &bus->timeout_cnt);
2260+
debugfs_create_u64("tx_complete_cnt", 0444, bus->adap.debugfs, &bus->tx_complete_cnt);
22742261
}
22752262

22762263
static int npcm_i2c_probe_bus(struct platform_device *pdev)
@@ -2362,7 +2349,6 @@ static void npcm_i2c_remove_bus(struct platform_device *pdev)
23622349
unsigned long lock_flags;
23632350
struct npcm_i2c *bus = platform_get_drvdata(pdev);
23642351

2365-
debugfs_remove_recursive(bus->debugfs);
23662352
spin_lock_irqsave(&bus->lock, lock_flags);
23672353
npcm_i2c_disable(bus);
23682354
spin_unlock_irqrestore(&bus->lock, lock_flags);
@@ -2385,28 +2371,7 @@ static struct platform_driver npcm_i2c_bus_driver = {
23852371
}
23862372
};
23872373

2388-
static int __init npcm_i2c_init(void)
2389-
{
2390-
int ret;
2391-
2392-
npcm_i2c_debugfs_dir = debugfs_create_dir("npcm_i2c", NULL);
2393-
2394-
ret = platform_driver_register(&npcm_i2c_bus_driver);
2395-
if (ret) {
2396-
debugfs_remove_recursive(npcm_i2c_debugfs_dir);
2397-
return ret;
2398-
}
2399-
2400-
return 0;
2401-
}
2402-
module_init(npcm_i2c_init);
2403-
2404-
static void __exit npcm_i2c_exit(void)
2405-
{
2406-
platform_driver_unregister(&npcm_i2c_bus_driver);
2407-
debugfs_remove_recursive(npcm_i2c_debugfs_dir);
2408-
}
2409-
module_exit(npcm_i2c_exit);
2374+
module_platform_driver(npcm_i2c_bus_driver);
24102375

24112376
MODULE_AUTHOR("Avi Fishman <avi.fishman@gmail.com>");
24122377
MODULE_AUTHOR("Tali Perry <tali.perry@nuvoton.com>");

0 commit comments

Comments
 (0)