Skip to content

Commit e2a61a7

Browse files
Jiri Slaby (SUSE)gregkh
authored andcommitted
6pack: drop sixpack::mtu
It holds a constant (AX25_MTU + 73), so use that constant in place of the single use directly. And remove the stale comment. Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Andreas Koensgen <ajk@comnets.uni-bremen.de> Cc: David S. Miller <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: linux-hams@vger.kernel.org Cc: netdev@vger.kernel.org Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au> Link: https://lore.kernel.org/r/20240808103549.429349-9-jirislaby@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 4c576b3 commit e2a61a7

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/net/hamradio/6pack.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ struct sixpack {
100100
unsigned int rx_count_cooked;
101101
spinlock_t rxlock;
102102

103-
int mtu; /* Our mtu (to spot changes!) */
104103
int buffsize; /* Max buffers sizes */
105104

106105
unsigned long flags; /* Flag values/ mode etc */
@@ -166,7 +165,7 @@ static void sp_encaps(struct sixpack *sp, unsigned char *icp, int len)
166165
unsigned char *msg, *p = icp;
167166
int actual, count;
168167

169-
if (len > sp->mtu) { /* sp->mtu = AX25_MTU = max. PACLEN = 256 */
168+
if (len > AX25_MTU + 73) {
170169
msg = "oversized transmit packet!";
171170
goto out_drop;
172171
}
@@ -585,7 +584,6 @@ static int sixpack_open(struct tty_struct *tty)
585584

586585
sp->xbuff = xbuff;
587586

588-
sp->mtu = AX25_MTU + 73;
589587
sp->buffsize = len;
590588
sp->rcount = 0;
591589
sp->rx_count = 0;

0 commit comments

Comments
 (0)