Skip to content

Commit e6df127

Browse files
spectrum70gregkh
authored andcommitted
iio: dac: ad3552r: clear reset status flag
commit e17b9f2 upstream. Clear reset status flag, to keep error status register clean after reset (ad3552r manual, rev B table 38). Reset error flag was left to 1, so debugging registers, the "Error Status Register" was dirty (0x01). It is important to clear this bit, so if there is any reset event over normal working mode, it is possible to detect it. Fixes: 8f2b548 ("drivers:iio:dac: Add AD3552R driver support") Signed-off-by: Angelo Dureghello <adureghello@baylibre.com> Link: https://patch.msgid.link/20250125-wip-bl-ad3552r-clear-reset-v2-1-aa3a27f3ff8c@baylibre.com Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 087d46e commit e6df127

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

drivers/iio/dac/ad3552r.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,12 @@ static int ad3552r_reset(struct ad3552r_desc *dac)
410410
return ret;
411411
}
412412

413+
/* Clear reset error flag, see ad3552r manual, rev B table 38. */
414+
ret = ad3552r_write_reg(dac, AD3552R_REG_ADDR_ERR_STATUS,
415+
AD3552R_MASK_RESET_STATUS);
416+
if (ret)
417+
return ret;
418+
413419
return ad3552r_update_reg_field(dac,
414420
AD3552R_REG_ADDR_INTERFACE_CONFIG_A,
415421
AD3552R_MASK_ADDR_ASCENSION,

0 commit comments

Comments
 (0)