net: ethernet: mtk_eth_soc: do not reset PSE when setting FE

frank-w · Paolo Abeni · commit e8716b5b0dff · 2025-05-06T13:37:34.000+02:00
Remove redundant PSE reset. When setting FE register there is no need to reset PSE, doing so may cause FE to work abnormal. Link: https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/3a5223473e086a4b54a2b9a44df7d9ddcc2bc75a Fixes: dee4dd1 ("net: ethernet: mtk_eth_soc: ppe: add support for multiple PPEs") Signed-off-by: Frank Wunderlich <frank-w@public-files.de> Link: https://patch.msgid.link/18f0ac7d83f82defa3342c11ef0d1362f6b81e88.1746406763.git.daniel@makrotopia.org Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -3473,9 +3473,6 @@ static int mtk_open(struct net_device *dev)
 			}
 			mtk_gdm_config(eth, target_mac->id, gdm_config);
 		}
-		/* Reset and enable PSE */
-		mtk_w32(eth, RST_GL_PSE, MTK_RST_GL);
-		mtk_w32(eth, 0, MTK_RST_GL);
 
 		napi_enable(&eth->tx_napi);
 		napi_enable(&eth->rx_napi);

Original file line number	Diff line number	Diff line change
`@@ -3473,9 +3473,6 @@ static int mtk_open(struct net_device *dev)`
`3473`	`3473`	`}`
`3474`	`3474`	`mtk_gdm_config(eth, target_mac->id, gdm_config);`
`3475`	`3475`	`}`
`3476`		`- /* Reset and enable PSE */`
`3477`		`- mtk_w32(eth, RST_GL_PSE, MTK_RST_GL);`
`3478`		`- mtk_w32(eth, 0, MTK_RST_GL);`
`3479`	`3476`
`3480`	`3477`	`napi_enable(&eth->tx_napi);`
`3481`	`3478`	`napi_enable(&eth->rx_napi);`