Skip to content

Commit e8ad595

Browse files
Chen Nijic23
authored andcommitted
iio: adc: stm32-adc: Fix race in installing chained IRQ handler
Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to irq_set_chained_handler_and_data(). Fixes: 1add698 ("iio: adc: Add support for STM32 ADC core") Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Reviewed-by: Nuno Sá <nuno.sa@analog.com> Tested-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Link: https://patch.msgid.link/20250515083101.3811350-1-nichen@iscas.ac.cn Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
1 parent 16285a0 commit e8ad595

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

drivers/iio/adc/stm32-adc-core.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -430,10 +430,9 @@ static int stm32_adc_irq_probe(struct platform_device *pdev,
430430
return -ENOMEM;
431431
}
432432

433-
for (i = 0; i < priv->cfg->num_irqs; i++) {
434-
irq_set_chained_handler(priv->irq[i], stm32_adc_irq_handler);
435-
irq_set_handler_data(priv->irq[i], priv);
436-
}
433+
for (i = 0; i < priv->cfg->num_irqs; i++)
434+
irq_set_chained_handler_and_data(priv->irq[i],
435+
stm32_adc_irq_handler, priv);
437436

438437
return 0;
439438
}

0 commit comments

Comments
 (0)