Skip to content

Commit eb4917f

Browse files
Yuuoniygregkh
authored andcommitted
serial: amba-pl011: prefer dma_mapping_error() over explicit address checking
Check for returned DMA addresses using specialized dma_mapping_error() helper which is generally recommended for this purpose by Documentation/core-api/dma-api.rst: "In some circumstances dma_map_single(), ... will fail to create a mapping. A driver can check for these errors by testing the returned DMA address with dma_mapping_error()." Found via static analysis and this is similar to commit fa03081 ("ALSA: memalloc: prefer dma_mapping_error() over explicit address checking") Fixes: 58ac1b3 ("ARM: PL011: Fix DMA support") Cc: stable <stable@kernel.org> Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com> Link: https://patch.msgid.link/20251027092053.87937-1-linmq006@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent dcb6fa3 commit eb4917f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/tty/serial/amba-pl011.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,7 @@ static int pl011_dma_tx_refill(struct uart_amba_port *uap)
628628
dmatx->len = count;
629629
dmatx->dma = dma_map_single(dma_dev->dev, dmatx->buf, count,
630630
DMA_TO_DEVICE);
631-
if (dmatx->dma == DMA_MAPPING_ERROR) {
631+
if (dma_mapping_error(dma_dev->dev, dmatx->dma)) {
632632
uap->dmatx.queued = false;
633633
dev_dbg(uap->port.dev, "unable to map TX DMA\n");
634634
return -EBUSY;

0 commit comments

Comments
 (0)