Skip to content

Commit ebd3330

Browse files
committed
SUNRPC: Improve "fragment too large" warning
Including the client IP address that generated the overrun traffic seems like it would be helpful. The message now reads: kernel: svc: nfsd oversized RPC fragment (1064958 octets) from 100.64.0.11:45866 Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent d686e64 commit ebd3330

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

net/sunrpc/svcsock.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1062,9 +1062,10 @@ static ssize_t svc_tcp_read_marker(struct svc_sock *svsk,
10621062
return svc_sock_reclen(svsk);
10631063

10641064
err_too_large:
1065-
net_notice_ratelimited("svc: %s %s RPC fragment too large: %d\n",
1066-
__func__, svsk->sk_xprt.xpt_server->sv_name,
1067-
svc_sock_reclen(svsk));
1065+
net_notice_ratelimited("svc: %s oversized RPC fragment (%u octets) from %pISpc\n",
1066+
svsk->sk_xprt.xpt_server->sv_name,
1067+
svc_sock_reclen(svsk),
1068+
(struct sockaddr *)&svsk->sk_xprt.xpt_remote);
10681069
svc_xprt_deferred_close(&svsk->sk_xprt);
10691070
err_short:
10701071
return -EAGAIN;

0 commit comments

Comments
 (0)