Skip to content

Commit ed07a76

Browse files
committed
drm/simpledrm: Use of_reserved_mem_region_to_resource() for "memory-region"
Use the newly added of_reserved_mem_region_to_resource() function to handle "memory-region" properties. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://lore.kernel.org/r/20250703183447.2073902-1-robh@kernel.org Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
1 parent 6b12afa commit ed07a76

1 file changed

Lines changed: 5 additions & 10 deletions

File tree

drivers/gpu/drm/sysfb/simpledrm.c

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#include <linux/clk.h>
55
#include <linux/of_clk.h>
66
#include <linux/minmax.h>
7-
#include <linux/of_address.h>
7+
#include <linux/of_reserved_mem.h>
88
#include <linux/platform_data/simplefb.h>
99
#include <linux/platform_device.h>
1010
#include <linux/pm_domain.h>
@@ -179,22 +179,17 @@ simplefb_get_format_of(struct drm_device *dev, struct device_node *of_node)
179179
static struct resource *
180180
simplefb_get_memory_of(struct drm_device *dev, struct device_node *of_node)
181181
{
182-
struct device_node *np;
183-
struct resource *res;
182+
struct resource r, *res;
184183
int err;
185184

186-
np = of_parse_phandle(of_node, "memory-region", 0);
187-
if (!np)
185+
err = of_reserved_mem_region_to_resource(of_node, 0, &r);
186+
if (err)
188187
return NULL;
189188

190-
res = devm_kzalloc(dev->dev, sizeof(*res), GFP_KERNEL);
189+
res = devm_kmemdup(dev->dev, &r, sizeof(r), GFP_KERNEL);
191190
if (!res)
192191
return ERR_PTR(-ENOMEM);
193192

194-
err = of_address_to_resource(np, 0, res);
195-
if (err)
196-
return ERR_PTR(err);
197-
198193
if (of_property_present(of_node, "reg"))
199194
drm_warn(dev, "preferring \"memory-region\" over \"reg\" property\n");
200195

0 commit comments

Comments
 (0)