Skip to content

Commit ed575d4

Browse files
rddunlapmartinkpetersen
authored andcommitted
scsi: mpi3mr: Fix kernel-doc issues in mpi3mr_app.c
Fix all kernel-doc problems in mpi3mr_app.c: mpi3mr_app.c:809: warning: Excess function parameter 'data' description in 'mpi3mr_set_trigger_data_in_hdb' mpi3mr_app.c:836: warning: Excess function parameter 'data' description in 'mpi3mr_set_trigger_data_in_all_hdb' mpi3mr_app.c:3395: warning: No description found for return value of 'sas_ncq_prio_supported_show' mpi3mr_app.c:3413: warning: No description found for return value of 'sas_ncq_prio_enable_show' Fixes: fc44449 ("scsi: mpi3mr: HDB allocation and posting for hardware and firmware buffers") Fixes: d8d08d1 ("scsi: mpi3mr: Trigger support") Fixes: 90e6f08 ("scsi: mpi3mr: Fix ATA NCQ priority support") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Link: https://lore.kernel.org/r/20250620162158.776795-1-rdunlap@infradead.org Cc: Sathya Prakash <sathya.prakash@broadcom.com> Cc: Kashyap Desai <kashyap.desai@broadcom.com> Cc: Sumit Saxena <sumit.saxena@broadcom.com> Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com> Cc: Ranjan Kumar <ranjan.kumar@broadcom.com> Cc: mpi3mr-linuxdrv.pdl@broadcom.com Cc: Damien Le Moal <dlemoal@kernel.org> Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com> Cc: Martin K. Petersen <martin.petersen@oracle.com> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent c7ee6c8 commit ed575d4

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

drivers/scsi/mpi3mr/mpi3mr_app.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -795,9 +795,8 @@ void mpi3mr_release_diag_bufs(struct mpi3mr_ioc *mrioc, u8 skip_rel_action)
795795
*
796796
* @hdb: HDB pointer
797797
* @type: Trigger type
798-
* @data: Trigger data
799-
* @force: Trigger overwrite flag
800798
* @trigger_data: Pointer to trigger data information
799+
* @force: Trigger overwrite flag
801800
*
802801
* Updates trigger type and trigger data based on parameter
803802
* passed to this function
@@ -822,9 +821,8 @@ void mpi3mr_set_trigger_data_in_hdb(struct diag_buffer_desc *hdb,
822821
*
823822
* @mrioc: Adapter instance reference
824823
* @type: Trigger type
825-
* @data: Trigger data
826-
* @force: Trigger overwrite flag
827824
* @trigger_data: Pointer to trigger data information
825+
* @force: Trigger overwrite flag
828826
*
829827
* Updates trigger type and trigger data based on parameter
830828
* passed to this function
@@ -3388,6 +3386,8 @@ static DEVICE_ATTR_RO(persistent_id);
33883386
* @buf: the buffer returned
33893387
*
33903388
* A sysfs 'read-only' sdev attribute, only works with SATA devices
3389+
*
3390+
* Returns: the number of characters written to @buf
33913391
*/
33923392
static ssize_t
33933393
sas_ncq_prio_supported_show(struct device *dev,
@@ -3406,6 +3406,8 @@ static DEVICE_ATTR_RO(sas_ncq_prio_supported);
34063406
* @buf: the buffer returned
34073407
*
34083408
* A sysfs 'read/write' sdev attribute, only works with SATA devices
3409+
*
3410+
* Returns: the number of characters written to @buf
34093411
*/
34103412
static ssize_t
34113413
sas_ncq_prio_enable_show(struct device *dev,

0 commit comments

Comments
 (0)