Skip to content

Commit ed683b9

Browse files
martinezjaviertdz
authored andcommitted
sparc: Fix undefined reference to fb_is_primary_device
Commit 55bffc8 ("fbdev: Split frame buffer support in FB and FB_CORE symbols") added a new FB_CORE Kconfig symbol, that can be enabled to only have fbcon/VT and DRM fbdev emulation, but without support for any legacy fbdev driver. Unfortunately, it missed to change the CONFIG_FB in arch/sparc makefiles, which leads to the following linking error in some sparc64 configurations: sparc64-linux-ld: drivers/video/fbdev/core/fbcon.o: in function `fbcon_fb_registered': >> fbcon.c:(.text+0x4f60): undefined reference to `fb_is_primary_device' Fixes: 55bffc8 ("fbdev: Split frame buffer support in FB and FB_CORE symbols") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/r/202401290306.IV8rhJ02-lkp@intel.com/ Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Arnd Bergmann <arnd@arndb.de> Cc: <stable@vger.kernel.org> # v6.6+ Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://patchwork.freedesktop.org/patch/msgid/20240220095428.3341195-1-javierm@redhat.com
1 parent eb0d253 commit ed683b9

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

arch/sparc/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ libs-y += arch/sparc/prom/
6060
libs-y += arch/sparc/lib/
6161

6262
drivers-$(CONFIG_PM) += arch/sparc/power/
63-
drivers-$(CONFIG_FB) += arch/sparc/video/
63+
drivers-$(CONFIG_FB_CORE) += arch/sparc/video/
6464

6565
boot := arch/sparc/boot
6666

arch/sparc/video/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# SPDX-License-Identifier: GPL-2.0-only
22

3-
obj-$(CONFIG_FB) += fbdev.o
3+
obj-$(CONFIG_FB_CORE) += fbdev.o

0 commit comments

Comments
 (0)