Skip to content

Commit ee13e1f

Browse files
bebarinovinodkoul
authored andcommitted
phy: qcom: qmp-combo: Fix register base for QSERDES_DP_PHY_MODE
The register base that was used to write to the QSERDES_DP_PHY_MODE register was 'dp_dp_phy' before commit 815891e ("phy: qcom-qmp-combo: Introduce orientation variable"). There isn't any explanation in the commit why this is changed, so I suspect it was an oversight or happened while being extracted from some other series. Oddly the value being 0x4c or 0x5c doesn't seem to matter for me, so I suspect this is dead code, but that can be fixed in another patch. It's not good to write to the wrong register space, and maybe some other version of this phy relies on this. Cc: Douglas Anderson <dianders@chromium.org> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Neil Armstrong <neil.armstrong@linaro.org> Cc: Abel Vesa <abel.vesa@linaro.org> Cc: Steev Klimaszewski <steev@kali.org> Cc: Johan Hovold <johan+linaro@kernel.org> Cc: Bjorn Andersson <quic_bjorande@quicinc.com> Cc: stable@vger.kernel.org # 6.5 Fixes: 815891e ("phy: qcom-qmp-combo: Introduce orientation variable") Signed-off-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/r/20240405000111.1450598-1-swboyd@chromium.org Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 5abed58 commit ee13e1f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/phy/qualcomm/phy-qcom-qmp-combo.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2153,9 +2153,9 @@ static bool qmp_combo_configure_dp_mode(struct qmp_combo *qmp)
21532153
writel(val, qmp->dp_dp_phy + QSERDES_DP_PHY_PD_CTL);
21542154

21552155
if (reverse)
2156-
writel(0x4c, qmp->pcs + QSERDES_DP_PHY_MODE);
2156+
writel(0x4c, qmp->dp_dp_phy + QSERDES_DP_PHY_MODE);
21572157
else
2158-
writel(0x5c, qmp->pcs + QSERDES_DP_PHY_MODE);
2158+
writel(0x5c, qmp->dp_dp_phy + QSERDES_DP_PHY_MODE);
21592159

21602160
return reverse;
21612161
}

0 commit comments

Comments
 (0)