scsi: lpfc: Remove redundant assignment to avoid memory leak

Jiasheng Jiang · martinkpetersen · commit eea6cafb5890 · 2025-08-05T22:05:40.000-04:00
Remove the redundant assignment if kzalloc() succeeds to avoid memory leak. Fixes: bd2cdd5 ("scsi: lpfc: NVME Initiator: Add debugfs support") Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com> Link: https://lore.kernel.org/r/20250801185202.42631-1-jiashengjiangcool@gmail.com Reviewed-by: Justin Tee <justin.tee@broadcom.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
@@ -6289,7 +6289,6 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport)
 			}
 			phba->nvmeio_trc_on = 1;
 			phba->nvmeio_trc_output_idx = 0;
-			phba->nvmeio_trc = NULL;
 		} else {
 nvmeio_off:
 			phba->nvmeio_trc_size = 0;

Original file line number	Diff line number	Diff line change
`@@ -6289,7 +6289,6 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport)`
`6289`	`6289`	`}`
`6290`	`6290`	`phba->nvmeio_trc_on = 1;`
`6291`	`6291`	`phba->nvmeio_trc_output_idx = 0;`
`6292`		`- phba->nvmeio_trc = NULL;`
`6293`	`6292`	`} else {`
`6294`	`6293`	`nvmeio_off:`
`6295`	`6294`	`phba->nvmeio_trc_size = 0;`