Skip to content

Commit efdddc4

Browse files
Noltarikuba-moo
authored andcommitted
net: dsa: tag_brcm: legacy: fix pskb_may_pull length
BRCM_LEG_PORT_ID was incorrectly used for pskb_may_pull length. The correct check is BRCM_LEG_TAG_LEN + VLAN_HLEN, or 10 bytes. Fixes: 964dbf1 ("net: dsa: tag_brcm: add support for legacy tags") Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Link: https://patch.msgid.link/20250529124406.2513779-1-noltari@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent d1a866d commit efdddc4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/dsa/tag_brcm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ static struct sk_buff *brcm_leg_tag_rcv(struct sk_buff *skb,
257257
int source_port;
258258
u8 *brcm_tag;
259259

260-
if (unlikely(!pskb_may_pull(skb, BRCM_LEG_PORT_ID)))
260+
if (unlikely(!pskb_may_pull(skb, BRCM_LEG_TAG_LEN + VLAN_HLEN)))
261261
return NULL;
262262

263263
brcm_tag = dsa_etype_header_pos_rx(skb);

0 commit comments

Comments
 (0)